Pokemon Emerald: Some dexsanity locations contribute evolution items #3187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a species evolves via item use (Fire Stone, Metal Coat, etc.), use that as it's vanilla item instead of a ball
github-actions
bot
added
the
waiting-on: peer-review
Zunawe
added
the
is: enhancement
…we/Archipelago into emerald-dexsanity-evo-items
Exempt-Medic
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Evolving pokemon isn't (currently) in-logic for dexsanity, but it's still common enough to do. But for some pokemon that evolve via item use, it can be difficult or impossible to find the relevant items.
This changes the "vanilla item" that dexsanity locations contribute if the species evolves by using those items. So with a
shuffleditem pool, there will always be enough evolution items to evolve all included species. And withdiverse_balancedthere will at least be a slightly higher concentration of evolution items.Also technically fixes a bug where
_str_to_evolution_methodwas missing theITEMmethod, which resulted in the value beingNonefor pokemon with evolution items. This value was never read anyway, so the bug had no effect.How was this tested?
Generated a game with a
shuffleditem pool and checked the counts for a few evolution items.